Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for PHP 8.3 #627

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Add Support for PHP 8.3 #627

merged 2 commits into from
Dec 18, 2023

Conversation

osrecio
Copy link
Contributor

@osrecio osrecio commented Dec 13, 2023

  • There is an issue ticket which accompanies my PR: .
  • I have followed the guidelines for contributing.
  • I have checked that there aren't other open pull requests for the same issue ticket.
  • I have formatted my code with the PSR-2 coding style before submitting my PR.

I have read the contribution guidelines and am targeting the branch 2.x:
Because this is a Feature which is not Backwards Compatible.

Changelog entry:
Added support for PHP 8.3
Short description of your work as explained by: Keep A Changelog.

@mischabraam
Copy link
Member

Nice, thanks.
I can merge this, but... I'm actually not supporting version 2. Version 3.x (which I will release soon) already supports PHP 8.3. To release version 3 I actually can use some help with testing it.

@mischabraam mischabraam merged commit 45876f9 into weprovide:2.x Dec 18, 2023
1 check failed
@lijithmg
Copy link

lijithmg commented Jul 3, 2024

Nice, thanks. I can merge this, but... I'm actually not supporting version 2. Version 3.x (which I will release soon) already supports PHP 8.3. To release version 3 I actually can use some help with testing it.

@mischabraam Not sure if 3.x version is supporting PHP 8.3. On the composer.json we have

"require": {
        "php": ">=7.1 <8.3",
        "laravel/valet": "^4.5"
    },

@mischabraam
Copy link
Member

Correct, that doesn't matter. :)
Valet-plus requires php 8.1 installed and active on your machine. It doesn't require php 8.1 to actually being linked. It will use php 8.1 no matter the current linked php version.
Next to that valet-plus requires laravel/valet under the hood. Laravel/valet handles all php install support, which includes the installation of php 8.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants