Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy for Drush commands #635

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

EHLOVader
Copy link
Contributor

This will ensure that isolated sites use the correct version of php with Drush.
User Login (ULI) has been improved with added uri which is known by Valet.
This requires the added command which-uri to output the domain without any protocol.

This will ensure that isolated sites use the correct version of php with Drush. User Login (ULI) has been improved with added uri which is known by Valet.
This requires the added command which-uri to output the domain without any protocol.
@mischabraam
Copy link
Member

mischabraam commented Mar 21, 2024

Thanks @EHLOVader !
What is the expected behavior of your suggested valet-plus which-uri command? I did a test with a site which has a couple of links, where this command gives my an unexpected result. See screenshot.

Screenshot_2024-03-21_at_10_54_51

I'm in the directory skantrae which gives me a working skantrae.test domain. I've also added some links for other storeviews like cando.test, deurtotaalmarkt.test and weekamp.test. The command valet-plus which-uri gives me cando.test which I didn't expect, I would expect skantrae.test.
Maybe this is still ok, I'm not sure. Can you elaborate on this?

@EHLOVader
Copy link
Contributor Author

Ah, that is interesting.

It was supposed to populate the URI in the ULI command so that the URL provided by the Drush command is clickable and openable.

It was meant to output the current folder's domain. But yeah this would have some issues with multisites. I wonder if there is a way to use the site aliases with this instead.

It uses the built in valet Site::domain method so I thought it would recognize the folder.

Does it open skantrae.test for you when you run valet open? That is what I based this on, but maybe I missed something there.

It could be rolled back to tighten the PR to just proxy, but I also wanted to PR the ULI system and didn't know how best to make them dependent on each other.

@mischabraam
Copy link
Member

Hmm no, it doesn't. It opens cando.test too. Ok, well, then I think we can approve this :) (yolo)

@mischabraam mischabraam merged commit c593deb into weprovide:3.x Mar 26, 2024
1 of 2 checks passed
mischabraam pushed a commit that referenced this pull request Mar 26, 2024
This will ensure that isolated sites use the correct version of php with Drush. User Login (ULI) has been improved with added uri which is known by Valet.
This requires the added command which-uri to output the domain without any protocol.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants