Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to instructions for unverified individuals and entities #394

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Link to instructions for unverified individuals and entities #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcf4e58
Link to instructions for unverified individuals and entities
jeremyroman Apr 25, 2024
dc2ea64
Use plural verbiage for multiple orgs as appropriate.
jeremyroman Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions __tests__/__snapshots__/get-user-status.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ exports[`Individual, participating in all workstreams, unverified 1`] = `
"context": "Participation",
"description": "@johndoetw is not yet verified",
"isNothing": false,
"longDescription": "@johndoetw has signed up to participate as an individual, but has not yet been verified. Hold tight while we sort this out on our end!",
"longDescription": "@johndoetw has signed up to participate as an individual, but has not yet been verified. Hold tight while we sort this out on our end! If you are a spec editor, follow <a href="https://github.com/whatwg/participate.whatwg.org#process-for-editors">these instructions</a> to verify this individual.",
"state": "pending",
"target_url": "https://participate.whatwg.org/agreement-status?user=johndoetw&repo=console",
}
Expand All @@ -60,7 +60,7 @@ exports[`Individual, participating in all workstreams, unverified 2`] = `
"context": "Participation",
"description": "@johndoetw is not yet verified",
"isNothing": false,
"longDescription": "@johndoetw has signed up to participate as an individual, but has not yet been verified. Hold tight while we sort this out on our end!",
"longDescription": "@johndoetw has signed up to participate as an individual, but has not yet been verified. Hold tight while we sort this out on our end! If you are a spec editor, follow <a href="https://github.com/whatwg/participate.whatwg.org#process-for-editors">these instructions</a> to verify this individual.",
"state": "pending",
"target_url": "https://participate.whatwg.org/agreement-status?user=johndoetw&repo=console&pull=120",
}
Expand Down Expand Up @@ -93,7 +93,7 @@ exports[`Individual, participating in other workstreams but not that one, unveri
"context": "Participation",
"description": "@johndoetw is not yet verified",
"isNothing": false,
"longDescription": "@johndoetw has signed up to participate as an individual, but has not yet been verified. Hold tight while we sort this out on our end!",
"longDescription": "@johndoetw has signed up to participate as an individual, but has not yet been verified. Hold tight while we sort this out on our end! If you are a spec editor, follow <a href="https://github.com/whatwg/participate.whatwg.org#process-for-editors">these instructions</a> to verify this individual.",
"state": "pending",
"target_url": "https://participate.whatwg.org/agreement-status?user=johndoetw&repo=console",
}
Expand All @@ -104,7 +104,7 @@ exports[`Individual, participating in other workstreams but not that one, unveri
"context": "Participation",
"description": "@johndoetw is not yet verified",
"isNothing": false,
"longDescription": "@johndoetw has signed up to participate as an individual, but has not yet been verified. Hold tight while we sort this out on our end!",
"longDescription": "@johndoetw has signed up to participate as an individual, but has not yet been verified. Hold tight while we sort this out on our end! If you are a spec editor, follow <a href="https://github.com/whatwg/participate.whatwg.org#process-for-editors">these instructions</a> to verify this individual.",
"state": "pending",
"target_url": "https://participate.whatwg.org/agreement-status?user=johndoetw&repo=console&pull=120",
}
Expand Down Expand Up @@ -137,7 +137,7 @@ exports[`Individual, participating in that particular workstream, unverified 1`]
"context": "Participation",
"description": "@johndoetw is not yet verified",
"isNothing": false,
"longDescription": "@johndoetw has signed up to participate as an individual, but has not yet been verified. Hold tight while we sort this out on our end!",
"longDescription": "@johndoetw has signed up to participate as an individual, but has not yet been verified. Hold tight while we sort this out on our end! If you are a spec editor, follow <a href="https://github.com/whatwg/participate.whatwg.org#process-for-editors">these instructions</a> to verify this individual.",
"state": "pending",
"target_url": "https://participate.whatwg.org/agreement-status?user=johndoetw&repo=console",
}
Expand All @@ -148,7 +148,7 @@ exports[`Individual, participating in that particular workstream, unverified 2`]
"context": "Participation",
"description": "@johndoetw is not yet verified",
"isNothing": false,
"longDescription": "@johndoetw has signed up to participate as an individual, but has not yet been verified. Hold tight while we sort this out on our end!",
"longDescription": "@johndoetw has signed up to participate as an individual, but has not yet been verified. Hold tight while we sort this out on our end! If you are a spec editor, follow <a href="https://github.com/whatwg/participate.whatwg.org#process-for-editors">these instructions</a> to verify this individual.",
"state": "pending",
"target_url": "https://participate.whatwg.org/agreement-status?user=johndoetw&repo=console&pull=120",
}
Expand Down Expand Up @@ -247,7 +247,7 @@ exports[`Multiple entities, all unverified 1`] = `
"context": "Participation",
"description": "@johndoetw participates on behalf of an unverified entity",
"isNothing": false,
"longDescription": "@johndoetw is part of the contoso1 and contoso2 GitHub organizations, but they all have not yet been verified. Hold tight while we sort this out on our end!",
"longDescription": "@johndoetw is part of the contoso1 and contoso2 GitHub organizations, but they all have not yet been verified. Hold tight while we sort this out on our end! If you are a spec editor, follow <a href="https://github.com/whatwg/participate.whatwg.org#process-for-editors">these instructions</a> to verify those organizations.",
"state": "pending",
"target_url": "https://participate.whatwg.org/agreement-status?user=johndoetw&repo=console",
}
Expand All @@ -258,7 +258,7 @@ exports[`Multiple entities, all unverified 2`] = `
"context": "Participation",
"description": "@johndoetw participates on behalf of an unverified entity",
"isNothing": false,
"longDescription": "@johndoetw is part of the contoso1 and contoso2 GitHub organizations, but they all have not yet been verified. Hold tight while we sort this out on our end!",
"longDescription": "@johndoetw is part of the contoso1 and contoso2 GitHub organizations, but they all have not yet been verified. Hold tight while we sort this out on our end! If you are a spec editor, follow <a href="https://github.com/whatwg/participate.whatwg.org#process-for-editors">these instructions</a> to verify those organizations.",
"state": "pending",
"target_url": "https://participate.whatwg.org/agreement-status?user=johndoetw&repo=console&pull=120",
}
Expand Down Expand Up @@ -401,7 +401,7 @@ exports[`Via entity, participating in all workstreams, unverified 1`] = `
"context": "Participation",
"description": "@johndoetw participates on behalf of an unverified entity",
"isNothing": false,
"longDescription": "@johndoetw is part of the contoso GitHub organization, but it has not yet been verified. Hold tight while we sort this out on our end!",
"longDescription": "@johndoetw is part of the contoso GitHub organization, but it has not yet been verified. Hold tight while we sort this out on our end! If you are a spec editor, follow <a href="https://github.com/whatwg/participate.whatwg.org#process-for-editors">these instructions</a> to verify this organization.",
"state": "pending",
"target_url": "https://participate.whatwg.org/agreement-status?user=johndoetw&repo=console",
}
Expand All @@ -412,7 +412,7 @@ exports[`Via entity, participating in all workstreams, unverified 2`] = `
"context": "Participation",
"description": "@johndoetw participates on behalf of an unverified entity",
"isNothing": false,
"longDescription": "@johndoetw is part of the contoso GitHub organization, but it has not yet been verified. Hold tight while we sort this out on our end!",
"longDescription": "@johndoetw is part of the contoso GitHub organization, but it has not yet been verified. Hold tight while we sort this out on our end! If you are a spec editor, follow <a href="https://github.com/whatwg/participate.whatwg.org#process-for-editors">these instructions</a> to verify this organization.",
"state": "pending",
"target_url": "https://participate.whatwg.org/agreement-status?user=johndoetw&repo=console&pull=120",
}
Expand Down Expand Up @@ -445,7 +445,7 @@ exports[`Via entity, participating in other workstreams but not that one, unveri
"context": "Participation",
"description": "@johndoetw participates on behalf of an unverified entity",
"isNothing": false,
"longDescription": "@johndoetw is part of the contoso GitHub organization, but it has not yet been verified. Hold tight while we sort this out on our end!",
"longDescription": "@johndoetw is part of the contoso GitHub organization, but it has not yet been verified. Hold tight while we sort this out on our end! If you are a spec editor, follow <a href="https://github.com/whatwg/participate.whatwg.org#process-for-editors">these instructions</a> to verify this organization.",
"state": "pending",
"target_url": "https://participate.whatwg.org/agreement-status?user=johndoetw&repo=console",
}
Expand All @@ -456,7 +456,7 @@ exports[`Via entity, participating in other workstreams but not that one, unveri
"context": "Participation",
"description": "@johndoetw participates on behalf of an unverified entity",
"isNothing": false,
"longDescription": "@johndoetw is part of the contoso GitHub organization, but it has not yet been verified. Hold tight while we sort this out on our end!",
"longDescription": "@johndoetw is part of the contoso GitHub organization, but it has not yet been verified. Hold tight while we sort this out on our end! If you are a spec editor, follow <a href="https://github.com/whatwg/participate.whatwg.org#process-for-editors">these instructions</a> to verify this organization.",
"state": "pending",
"target_url": "https://participate.whatwg.org/agreement-status?user=johndoetw&repo=console&pull=120",
}
Expand Down Expand Up @@ -489,7 +489,7 @@ exports[`Via entity, participating in that particular workstream, unverified 1`]
"context": "Participation",
"description": "@johndoetw participates on behalf of an unverified entity",
"isNothing": false,
"longDescription": "@johndoetw is part of the contoso GitHub organization, but it has not yet been verified. Hold tight while we sort this out on our end!",
"longDescription": "@johndoetw is part of the contoso GitHub organization, but it has not yet been verified. Hold tight while we sort this out on our end! If you are a spec editor, follow <a href="https://github.com/whatwg/participate.whatwg.org#process-for-editors">these instructions</a> to verify this organization.",
"state": "pending",
"target_url": "https://participate.whatwg.org/agreement-status?user=johndoetw&repo=console",
}
Expand All @@ -500,7 +500,7 @@ exports[`Via entity, participating in that particular workstream, unverified 2`]
"context": "Participation",
"description": "@johndoetw participates on behalf of an unverified entity",
"isNothing": false,
"longDescription": "@johndoetw is part of the contoso GitHub organization, but it has not yet been verified. Hold tight while we sort this out on our end!",
"longDescription": "@johndoetw is part of the contoso GitHub organization, but it has not yet been verified. Hold tight while we sort this out on our end! If you are a spec editor, follow <a href="https://github.com/whatwg/participate.whatwg.org#process-for-editors">these instructions</a> to verify this organization.",
"state": "pending",
"target_url": "https://participate.whatwg.org/agreement-status?user=johndoetw&repo=console&pull=120",
}
Expand Down
3 changes: 2 additions & 1 deletion config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@
"serverURL": "https://participate.whatwg.org/",
"statusPath": "/agreement-status",
"steeringGroupEmail": "[email protected]",
"specOrg": "whatwg"
"specOrg": "whatwg",
"verifyInstructionsURL": "https://github.com/whatwg/participate.whatwg.org#process-for-editors"
}
6 changes: 3 additions & 3 deletions lib/get-user-status.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ function statusIndividualUnverified(submitterGitHubID, targetURL) {
context: "Participation",

isNothing: false,
longDescription: html`@${submitterGitHubID} has signed up to participate as an individual, but has not yet been verified. Hold tight while we sort this out on our end!`
longDescription: html`@${submitterGitHubID} has signed up to participate as an individual, but has not yet been verified. Hold tight while we sort this out on our end! If you are a spec editor, follow <a href="${config.verifyInstructionsURL}">these instructions</a> to verify this individual.`
};
}

Expand All @@ -129,7 +129,7 @@ function statusEntity(submitterGitHubID, repoName, targetURL, entity) {
}

function statusEntitiesUnverified(submitterGitHubID, targetURL, entities) {
const { orgs, word, pronoun, haveVerb } = entityVerbiage(entities);
const { orgs, word, pronoun, pronoun2, haveVerb } = entityVerbiage(entities);

return {
state: "pending",
Expand All @@ -138,7 +138,7 @@ function statusEntitiesUnverified(submitterGitHubID, targetURL, entities) {
context: "Participation",

isNothing: false,
longDescription: html`@${submitterGitHubID} is part of the ${orgs} GitHub ${word}, but ${pronoun} ${haveVerb} not yet been verified. Hold tight while we sort this out on our end!`
longDescription: html`@${submitterGitHubID} is part of the ${orgs} GitHub ${word}, but ${pronoun} ${haveVerb} not yet been verified. Hold tight while we sort this out on our end! If you are a spec editor, follow <a href="${config.verifyInstructionsURL}">these instructions</a> to verify ${pronoun2} ${word}.`
};
}

Expand Down