Correct license specifiers #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
=====================================
Coverage 3.73% 3.73%
=====================================
Files 38 38
Lines 2815 2815
=====================================
Hits 105 105
Misses 2710 2710 ☔ View full report in Codecov by Sentry. |
|
I use it at work for quite some time and it's nice! |
Yeh it's quite cool. I have it on a scheduled pipeline and on every merge request now on Whisperfish, which should transitively also warn us about issues in here :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm messing around with
cargo deny, and noticed that the licenses were unspecified in Cargo.toml for the implementation crates, and it was plain wrong in the main crate. License should be AGPL-3.0 for all.We may want to start using
cargo denyin CI here too, but I'll toy around in Whisperfish first.