Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade aes 0.7 -> 0.8 #247

Merged
merged 12 commits into from
Jan 3, 2024
Merged

Upgrade aes 0.7 -> 0.8 #247

merged 12 commits into from
Jan 3, 2024

Conversation

boxdot
Copy link
Contributor

@boxdot boxdot commented Sep 23, 2023

Now libsignal 0.32 is used, aes can be upgraded to the next version. In
particular, this removes duplicated dependencies.

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (9af1f42) 3.62% compared to head (5f5577b) 3.64%.
Report is 2 commits behind head on main.

Files Patch % Lines
libsignal-service/src/account_manager.rs 0.00% 8 Missing ⚠️
libsignal-service/src/profile_cipher.rs 0.00% 6 Missing ⚠️
libsignal-service/src/provisioning/cipher.rs 0.00% 6 Missing ⚠️
libsignal-service/src/attachment_cipher.rs 0.00% 3 Missing ⚠️
libsignal-service/src/websocket.rs 0.00% 3 Missing ⚠️
libsignal-service/src/cipher.rs 0.00% 2 Missing ⚠️
libsignal-service/src/envelope.rs 0.00% 2 Missing ⚠️
libsignal-service/src/push_service.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #247      +/-   ##
========================================
+ Coverage   3.62%   3.64%   +0.01%     
========================================
  Files         37      37              
  Lines       2841    2828      -13     
========================================
  Hits         103     103              
+ Misses      2738    2725      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rubdos rubdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you comment on the try_into() that happens everywhere? Sounds like these should be using fixed-size arrays from the get-go, instead of dynamic conversions.

I would also suggest we merge #248 before this, then we know whether it is 1.61 compatible.

libsignal-service/src/attachment_cipher.rs Outdated Show resolved Hide resolved
@direc85 direc85 mentioned this pull request Nov 26, 2023
@rubdos rubdos merged commit 1858813 into whisperfish:main Jan 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants