-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade aes 0.7 -> 0.8 #247
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
========================================
+ Coverage 3.62% 3.64% +0.01%
========================================
Files 37 37
Lines 2841 2828 -13
========================================
Hits 103 103
+ Misses 2738 2725 -13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you comment on the try_into()
that happens everywhere? Sounds like these should be using fixed-size arrays from the get-go, instead of dynamic conversions.
I would also suggest we merge #248 before this, then we know whether it is 1.61 compatible.
Now libsignal 0.32 is used, aes can be upgraded to the next version. In
particular, this removes duplicated dependencies.