Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking as secondary device #271

Merged
merged 8 commits into from
Dec 17, 2023
Merged

Fix linking as secondary device #271

merged 8 commits into from
Dec 17, 2023

Conversation

gferon
Copy link
Collaborator

@gferon gferon commented Dec 16, 2023

Extracted from whisperfish/presage#220 with relevant refactoring and cleanups.

@gferon gferon marked this pull request as ready for review December 16, 2023 22:40
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 53 lines in your changes are missing coverage. Please review.

Comparison is base (9f81c52) 3.65% compared to head (8bef855) 3.62%.

❗ Current head 8bef855 differs from pull request most recent head e7085c0. Consider uploading reports for the commit e7085c0 to get more accurate results

Files Patch % Lines
libsignal-service/src/push_service.rs 0.00% 26 Missing ⚠️
libsignal-service/src/provisioning/mod.rs 0.00% 19 Missing ⚠️
libsignal-service/src/account_manager.rs 0.00% 7 Missing ⚠️
libsignal-service/src/provisioning/cipher.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #271      +/-   ##
========================================
- Coverage   3.65%   3.62%   -0.03%     
========================================
  Files         38      37       -1     
  Lines       2818    2841      +23     
========================================
  Hits         103     103              
- Misses      2715    2738      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

libsignal-service/src/provisioning/manager.rs Outdated Show resolved Hide resolved
libsignal-service/src/provisioning/manager.rs Outdated Show resolved Hide resolved
libsignal-service/src/provisioning/manager.rs Outdated Show resolved Hide resolved
libsignal-service/src/provisioning/manager.rs Outdated Show resolved Hide resolved
libsignal-service/src/provisioning/manager.rs Outdated Show resolved Hide resolved
@gferon gferon enabled auto-merge (squash) December 17, 2023 13:20
@gferon gferon merged commit 9af1f42 into main Dec 17, 2023
11 checks passed
@gferon gferon deleted the fix-linking branch December 17, 2023 13:22
boxdot added a commit to boxdot/gurk-rs that referenced this pull request Dec 18, 2023
This commit upgrades presage to the latest available version. In
particular, It includes the fix for the linking of secondary devices.

For reference, the fix was done in:

<whisperfish/presage#220>
<whisperfish/presage#221>
<whisperfish/libsignal-service-rs#271>

Closes #250
boxdot added a commit to boxdot/gurk-rs that referenced this pull request Dec 18, 2023
This commit upgrades presage to the latest available version. In
particular, It includes the fix for the linking of secondary devices.

For reference, the fix was done in:

<whisperfish/presage#220>
<whisperfish/presage#221>
<whisperfish/libsignal-service-rs#271>

Closes #250
@rubdos rubdos mentioned this pull request Jan 14, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants