Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to attachments v4 #330

Merged
merged 5 commits into from
Oct 20, 2024
Merged

Switch to attachments v4 #330

merged 5 commits into from
Oct 20, 2024

Conversation

gferon
Copy link
Collaborator

@gferon gferon commented Oct 13, 2024

which means dropping CDN0 which was AWS CloudFront and use CDN2 or CDN3 depending on what the server tells us to do.

TODO:

  • Make sure we still have post_to_cdn0 functional, even though I'm not sure whether it is used or not.
  • Add logic for CDN2 (we cannot know whether it is still in use or not, the server tells us to use it).

In general, I'd like to ditch libsignal-service-actix since it is not used anymore, which in turn will let us remove the PushService trait and let us have a much nicer direct access to the HTTP API.

Closes #320

@gferon gferon marked this pull request as ready for review October 20, 2024 17:56
Copy link
Member

@rubdos rubdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor suggestions (one is clippy, easily applied). This is very pretty code, well done.

src/push_service/cdn.rs Show resolved Hide resolved
src/push_service/cdn.rs Outdated Show resolved Hide resolved
src/push_service/mod.rs Show resolved Hide resolved
src/push_service/cdn.rs Show resolved Hide resolved
@gferon gferon merged commit 9540bc0 into main Oct 20, 2024
7 checks passed
@gferon gferon deleted the attachments-v4 branch October 20, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attachment uploads to cdn0 are now rejected under latest Signal for ios
2 participants