-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to attachments v4 #330
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubdos
reviewed
Oct 14, 2024
rubdos
reviewed
Oct 14, 2024
gferon
force-pushed
the
attachments-v4
branch
from
October 20, 2024 17:54
4b3bacf
to
9c2d865
Compare
rubdos
approved these changes
Oct 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very minor suggestions (one is clippy, easily applied). This is very pretty code, well done.
gferon
force-pushed
the
attachments-v4
branch
from
October 20, 2024 19:03
9c2d865
to
d39ec4c
Compare
gferon
force-pushed
the
attachments-v4
branch
from
October 20, 2024 19:06
ea2a99b
to
4e49b1b
Compare
rubdos
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which means dropping CDN0 which was AWS CloudFront and use CDN2 or CDN3 depending on what the server tells us to do.
TODO:
post_to_cdn0
functional, even though I'm not sure whether it is used or not.In general, I'd like to ditch
libsignal-service-actix
since it is not used anymore, which in turn will let us remove thePushService
trait and let us have a much nicer direct access to the HTTP API.Closes #320