-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ServiceAddress by libsignal_protocol::ServiceId #334
Conversation
f253894
to
1d3e40e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The strong types for Aci and Pni are awesome! Clippy has a useful suggestion too ;-)
Co-authored-by: Ruben De Smet <[email protected]>
ceda59d
to
ddbcd3b
Compare
029b52e
to
0a3940c
Compare
I think this is ready to 🚢 Regarding your suggestions to use |
I hid a bunch of mistakes in there just to check if @rubdos is paying attention (jk, I think it should be fine).
This definitely changes some things, like in some cases when preparing protos, you would get the prefixed
service_id_string
for PNI (which was the raw UUID before). I'm pretty sure it didn't use to work correctly.Thank you for reading.