Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap libsignal-protocol dependency with libsignal-client #83

Merged
merged 24 commits into from
Apr 30, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
76758f0
Swap libsignal-protocol dependency with libsignal-client
rubdos Apr 20, 2021
c4110d2
part 1
rubdos Apr 20, 2021
f4615cc
rand 0.7 because of compatibility
rubdos Apr 20, 2021
9e61ecf
part 2
rubdos Apr 20, 2021
adc795d
Merge remote-tracking branch 'upstream/master' into libsignal-client
gferon Apr 26, 2021
04788d8
Progress towards using the new libsignal-protocol in Rust
gferon Apr 26, 2021
5a3531e
Fix HKDF usage
gferon Apr 27, 2021
839baaa
Use dynamic dispatch and fix tests
gferon Apr 27, 2021
3419aa9
Adjust usage of verify_signature
gferon Apr 27, 2021
66b8969
Remove FIXME
gferon Apr 27, 2021
926d062
Last changes before shipping\!
gferon Apr 27, 2021
53dddee
Last changes before shipping!
gferon Apr 27, 2021
c867547
Merge remote-tracking branch 'upstream/master' into libsignal-client
gferon Apr 27, 2021
f1ae701
Use upstream libsignal-client
gferon Apr 27, 2021
1829246
Address review comments
gferon Apr 27, 2021
6e00342
Merge remote-tracking branch 'upstream/master' into libsignal-client
boxdot Apr 29, 2021
0ab27c5
Merge pull request #1 from boxdot/libsignal-client
gferon Apr 29, 2021
4436018
Merge remote-tracking branch 'fork/libsignal-client' into libsignal-c…
gferon Apr 29, 2021
1365782
Use static dispatch
gferon Apr 29, 2021
f6c4df7
Derive clone on ciphers and sender/receiver
gferon Apr 30, 2021
797dead
Fix clippy warnings
gferon Apr 30, 2021
a3be3d5
Add get_sub_device_sessions method to ServiceAddress
gferon Apr 30, 2021
4a5cfa2
Change license to AGPLv3
rubdos Apr 30, 2021
ead122e
Reflect license and copyright changes in README
rubdos Apr 30, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
158 changes: 99 additions & 59 deletions LICENSE.md
Original file line number Diff line number Diff line change
@@ -1,23 +1,21 @@
GNU GENERAL PUBLIC LICENSE
Version 3, 29 June 2007
GNU AFFERO GENERAL PUBLIC LICENSE
Version 3, 19 November 2007

Copyright (C) 2007 Free Software Foundation, Inc. <http://fsf.org/>
Copyright (C) 2007 Free Software Foundation, Inc. <https://fsf.org/>
Everyone is permitted to copy and distribute verbatim copies
of this license document, but changing it is not allowed.

Preamble

The GNU General Public License is a free, copyleft license for
software and other kinds of works.
The GNU Affero General Public License is a free, copyleft license for
software and other kinds of works, specifically designed to ensure
cooperation with the community in the case of network server software.

The licenses for most software and other practical works are designed
to take away your freedom to share and change the works. By contrast,
the GNU General Public License is intended to guarantee your freedom to
our General Public Licenses are intended to guarantee your freedom to
share and change all versions of a program--to make sure it remains free
software for all its users. We, the Free Software Foundation, use the
GNU General Public License for most of our software; it applies also to
any other work released this way by its authors. You can apply it to
your programs, too.
software for all its users.

When we speak of free software, we are referring to freedom, not
price. Our General Public Licenses are designed to make sure that you
Expand All @@ -26,44 +24,34 @@ them if you wish), that you receive source code or can get it if you
want it, that you can change the software or use pieces of it in new
free programs, and that you know you can do these things.

To protect your rights, we need to prevent others from denying you
these rights or asking you to surrender the rights. Therefore, you have
certain responsibilities if you distribute copies of the software, or if
you modify it: responsibilities to respect the freedom of others.

For example, if you distribute copies of such a program, whether
gratis or for a fee, you must pass on to the recipients the same
freedoms that you received. You must make sure that they, too, receive
or can get the source code. And you must show them these terms so they
know their rights.

Developers that use the GNU GPL protect your rights with two steps:
(1) assert copyright on the software, and (2) offer you this License
giving you legal permission to copy, distribute and/or modify it.

For the developers' and authors' protection, the GPL clearly explains
that there is no warranty for this free software. For both users' and
authors' sake, the GPL requires that modified versions be marked as
changed, so that their problems will not be attributed erroneously to
authors of previous versions.

Some devices are designed to deny users access to install or run
modified versions of the software inside them, although the manufacturer
can do so. This is fundamentally incompatible with the aim of
protecting users' freedom to change the software. The systematic
pattern of such abuse occurs in the area of products for individuals to
use, which is precisely where it is most unacceptable. Therefore, we
have designed this version of the GPL to prohibit the practice for those
products. If such problems arise substantially in other domains, we
stand ready to extend this provision to those domains in future versions
of the GPL, as needed to protect the freedom of users.

Finally, every program is threatened constantly by software patents.
States should not allow patents to restrict development and use of
software on general-purpose computers, but in those that do, we wish to
avoid the special danger that patents applied to a free program could
make it effectively proprietary. To prevent this, the GPL assures that
patents cannot be used to render the program non-free.
Developers that use our General Public Licenses protect your rights
with two steps: (1) assert copyright on the software, and (2) offer
you this License which gives you legal permission to copy, distribute
and/or modify the software.

A secondary benefit of defending all users' freedom is that
improvements made in alternate versions of the program, if they
receive widespread use, become available for other developers to
incorporate. Many developers of free software are heartened and
encouraged by the resulting cooperation. However, in the case of
software used on network servers, this result may fail to come about.
The GNU General Public License permits making a modified version and
letting the public access it on a server without ever releasing its
source code to the public.

The GNU Affero General Public License is designed specifically to
ensure that, in such cases, the modified source code becomes available
to the community. It requires the operator of a network server to
provide the source code of the modified version running there to the
users of that server. Therefore, public use of a modified version, on
a publicly accessible server, gives the public access to the source
code of the modified version.

An older license, called the Affero General Public License and
published by Affero, was designed to accomplish similar goals. This is
a different license, not a version of the Affero GPL, but Affero has
released a new version of the Affero GPL which permits relicensing under
this license.

The precise terms and conditions for copying, distribution and
modification follow.
Expand All @@ -72,7 +60,7 @@ modification follow.

0. Definitions.

"This License" refers to version 3 of the GNU General Public License.
"This License" refers to version 3 of the GNU Affero General Public License.

"Copyright" also means copyright-like laws that apply to other kinds of
works, such as semiconductor masks.
Expand Down Expand Up @@ -549,35 +537,45 @@ to collect a royalty for further conveying from those to whom you convey
the Program, the only way you could satisfy both those terms and this
License would be to refrain entirely from conveying the Program.

13. Use with the GNU Affero General Public License.
13. Remote Network Interaction; Use with the GNU General Public License.

Notwithstanding any other provision of this License, if you modify the
Program, your modified version must prominently offer all users
interacting with it remotely through a computer network (if your version
supports such interaction) an opportunity to receive the Corresponding
Source of your version by providing access to the Corresponding Source
from a network server at no charge, through some standard or customary
means of facilitating copying of software. This Corresponding Source
shall include the Corresponding Source for any work covered by version 3
of the GNU General Public License that is incorporated pursuant to the
following paragraph.

Notwithstanding any other provision of this License, you have
permission to link or combine any covered work with a work licensed
under version 3 of the GNU Affero General Public License into a single
under version 3 of the GNU General Public License into a single
combined work, and to convey the resulting work. The terms of this
License will continue to apply to the part which is the covered work,
but the special requirements of the GNU Affero General Public License,
section 13, concerning interaction through a network will apply to the
combination as such.
but the work with which it is combined will remain governed by version
3 of the GNU General Public License.

14. Revised Versions of this License.

The Free Software Foundation may publish revised and/or new versions of
the GNU General Public License from time to time. Such new versions will
be similar in spirit to the present version, but may differ in detail to
the GNU Affero General Public License from time to time. Such new versions
will be similar in spirit to the present version, but may differ in detail to
address new problems or concerns.

Each version is given a distinguishing version number. If the
Program specifies that a certain numbered version of the GNU General
Program specifies that a certain numbered version of the GNU Affero General
Public License "or any later version" applies to it, you have the
option of following the terms and conditions either of that numbered
version or of any later version published by the Free Software
Foundation. If the Program does not specify a version number of the
GNU General Public License, you may choose any version ever published
GNU Affero General Public License, you may choose any version ever published
by the Free Software Foundation.

If the Program specifies that a proxy can decide which future
versions of the GNU General Public License can be used, that proxy's
versions of the GNU Affero General Public License can be used, that proxy's
public statement of acceptance of a version permanently authorizes you
to choose that version for the Program.

Expand Down Expand Up @@ -619,3 +617,45 @@ Program, unless a warranty or assumption of liability accompanies a
copy of the Program in return for a fee.

END OF TERMS AND CONDITIONS

How to Apply These Terms to Your New Programs

If you develop a new program, and you want it to be of the greatest
possible use to the public, the best way to achieve this is to make it
free software which everyone can redistribute and change under these terms.

To do so, attach the following notices to the program. It is safest
to attach them to the start of each source file to most effectively
state the exclusion of warranty; and each file should have at least
the "copyright" line and a pointer to where the full notice is found.

<one line to give the program's name and a brief idea of what it does.>
Copyright (C) <year> <name of author>

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU Affero General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU Affero General Public License for more details.

You should have received a copy of the GNU Affero General Public License
along with this program. If not, see <https://www.gnu.org/licenses/>.

Also add information on how to contact you by electronic and paper mail.

If your software can interact with users remotely through a computer
network, you should also make sure that it provides a way for users to
get its source. For example, if your program is a web application, its
interface could display a "Source" link that leads users to an archive
of the code. There are many ways you could offer source, and different
solutions will be better for different programs; see section 13 for the
specific requirements.

You should also get your employer (if you work as a programmer) or school,
if any, to sign a "copyright disclaimer" for the program, if necessary.
For more information on this, and how to apply and follow the GNU AGPL, see
<https://www.gnu.org/licenses/>.
11 changes: 8 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,14 @@ If you're looking to contribute or want to ask a question, you're more than welc

## License

Copyright 2015-2019 Open Whisper Systems

Licensed under the GPLv3: http://www.gnu.org/licenses/gpl-3.0.html
Copyright 2015-2019 Open Whisper Systems
Copyright 2020-2021 Signal Messenger, LLC
Copyright 2019-2021 Ruben De Smet
Copyright 2019-2021 Michael F Bryan
Copyright 2019-2021 Gabriel Féron
Copyright 2019-2021 Whisperfish contributors

Licensed under the AGPLv3: http://www.gnu.org/licenses/agpl-3.0.html

Additional Permissions For Submission to Apple App Store: Provided that you
are otherwise in compliance with the GPLv3 for each covered work you convey
Expand Down
7 changes: 2 additions & 5 deletions libsignal-service-actix/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,8 @@ version = "0.1.0"
authors = ["Ruben De Smet <[email protected]>"]
edition = "2018"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
libsignal-service = { path = "../libsignal-service" }
libsignal-protocol = { git = "https://github.com/Michael-F-Bryan/libsignal-protocol-rs" }

awc = { version = "3.0.0-beta.5", features=["rustls"] }
actix = "0.11.1"
Expand All @@ -22,7 +19,7 @@ rustls = "0.19"
url = "2.1"
serde = "1.0"
log = "0.4"
rand = "0.8"
rand = "0.7"

failure = "0.1.5"
thiserror = "1.0"
Expand All @@ -36,6 +33,6 @@ env_logger = "0.8"
image = { version = "0.23", default-features = false, features = ["png"] }
opener = "0.4"
qrcode = "0.12"
rand = "0.8"
rand = "0.7"
structopt = "0.3"
tokio = { version = "1", features=["macros"] }
23 changes: 9 additions & 14 deletions libsignal-service-actix/examples/link.rs
Original file line number Diff line number Diff line change
@@ -1,20 +1,16 @@
use failure::Error;
use futures::{channel::mpsc::channel, future, StreamExt};
use image::Luma;
use libsignal_service::configuration::SignalServers;
use libsignal_service::{
configuration::SignalServers, provisioning::LinkingManager,
provisioning::SecondaryDeviceProvisioning, USER_AGENT,
};
use libsignal_service_actix::prelude::AwcPushService;
use log::LevelFilter;
use qrcode::QrCode;
use rand::{distributions::Alphanumeric, Rng, RngCore};
use structopt::StructOpt;

use libsignal_protocol::Context;

use libsignal_service::{
provisioning::LinkingManager, provisioning::SecondaryDeviceProvisioning,
USER_AGENT,
};
use libsignal_service_actix::prelude::AwcPushService;

#[derive(Debug, StructOpt)]
struct Args {
#[structopt(long = "servers", short = "s", default_value = "staging")]
Expand All @@ -36,8 +32,7 @@ async fn main() -> Result<(), Error> {

// generate a random 16 bytes password
let mut rng = rand::rngs::OsRng::default();
let password: Vec<u8> = rng.sample_iter(&Alphanumeric).take(24).collect();
let password = String::from_utf8(password)?;
let password: String = rng.sample_iter(&Alphanumeric).take(24).collect();

// generate a 52 bytes signaling key
let mut signaling_key = [0u8; 52];
Expand All @@ -47,16 +42,16 @@ async fn main() -> Result<(), Error> {
base64::encode(&signaling_key.to_vec())
);

let signal_context = Context::default();

let mut provision_manager: LinkingManager<AwcPushService> =
LinkingManager::new(args.servers, USER_AGENT.into(), password);

let (tx, mut rx) = channel(1);

let mut csprng = rand::thread_rng();

let (fut1, fut2) = future::join(
provision_manager.provision_secondary_device(
&signal_context,
&mut csprng,
signaling_key,
&args.device_name,
tx,
Expand Down
3 changes: 0 additions & 3 deletions libsignal-service-hyper/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,8 @@ version = "0.1.0"
authors = ["Gabriel Féron <[email protected]>"]
edition = "2018"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
libsignal-service = { path = "../libsignal-service" }
libsignal-protocol = { git = "https://github.com/Michael-F-Bryan/libsignal-protocol-rs" }

async-trait = "0.1"
base64 = "0.13"
Expand Down
7 changes: 4 additions & 3 deletions libsignal-service/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ license = "GPLv3"
readme = "../README.md"

[dependencies]
libsignal-protocol = { git = "https://github.com/Michael-F-Bryan/libsignal-protocol-rs" }
zkgroup = { git = "https://github.com/signalapp/zkgroup" }
libsignal-protocol = { git = "https://github.com/signalapp/libsignal-client" }
rubdos marked this conversation as resolved.
Show resolved Hide resolved
zkgroup = { git = "https://github.com/signalapp/zkgroup", tag = "v0.7.2" }
async-trait = "0.1.30"
url = { version = "2.1.1", features = ["serde"] }
base64 = "0.13"
Expand All @@ -30,7 +30,7 @@ aes = "0.6.0"
aes-gcm = "0.8.0"
aes-ctr = "0.6.0"
block-modes = "0.7.0"
rand = "0.8.0"
rand = "0.7"

uuid = { version = "0.8", features = [ "serde" ] }
phonenumber = "0.3"
Expand All @@ -40,6 +40,7 @@ prost-build = "0.7"

[dev-dependencies]
anyhow = "1.0"
tokio = { version = "1.0", features = [ "macros" ] }

[features]
prefer-e164 = []
Loading