Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YiR] Update flow to show collective for logged out users #5085

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tonisevener
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T379796

Notes

This PR removes the requirement that a user must be eligible to see at least one personalized slide for the entry point to appear. It also defaults to all collective slides from the coordinator if the user is logged out.

Test Steps

  1. Ensure device/simulator is in target region. Fresh install app. Log out of app if needed. Go to app Settings and turn off Year in Review. Build up an article history. Now go to app settings and turn ON year in review.
  2. Year in Review entry point should show in Profile.
  3. You should only see collective slides.
  4. Complete year in review flow, answer survey, then log into an account with edits after login prompt.
  5. After logging in, go back to year in review flow from Profile.
  6. You should see personalized slides now.
  7. Go back to profile, log out.
  8. After logging out, go back to year in review flow from Profile.
  9. You should only see collective slides now.

Copy link
Collaborator

@l-olson1214 l-olson1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing the first two slides as being personalized on log out, but that may have also included some of the merge conflicts - let's meet up when you're back from PTO!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants