Additional signature and quote catches #68
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catches signature and quotes for Windows 10 Mail.
I've probably made this too generalized, but I needed to catch signature and quotes coming from Mail for Windows 10. They look like this...
Unfortunately, the existing regex's miss both the signature and the quote. The signature is missed because it lacks a "my" after "Sent from", so I just went ahead and removed the "my" requirement. The quote is missed because the "From:" line only includes a name and lacks an email address in brackets. I loosened it up to only bother checking for a line beginning with "From:".
This is probably related to Issue #66. I haven't run the unit tests, and I'm pretty sure these fixes loosen things up too much, so not exactly suggesting this be merged in as-is. Hoping someone better at regex's comes up with a more proper fix, honestly :)