Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow you to pass savon client configuration options #27

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

drubin
Copy link

@drubin drubin commented Jun 2, 2015

I fixed the specs as well.

Hope this is ok? I wanted to make it generic enough to allow you to pass through any configuration options directly to Savon.

Also updated the readme to include some defaults.

@wingrunr21
Copy link
Owner

There should not be a savon_globals option. You should be able to pass in arbitrary configuration parameters and we just consume what we care about. The rest should be delegated on to Savon itself:

MindBody.configure do |config|
  config.site_ids    = -99 # Consumed
  config.source_key  = 'abcd1234' # Consumed
  config.source_name = 'SuperFoo' #Consumed
  config.log_level   = :info # Passed to Savon
  config.encoding = 'UTF-8' # Passed to Savon
  ... #etc
end

This also allows log_level, open_timeout, read_timeout to once again be Savon's responsibility.

@drubin
Copy link
Author

drubin commented Jun 3, 2015

References #26

@wingrunr21 the internals might need some clean up but the API should remain consistent and allows us to only use the configs we care about everything else is passed through to Savon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants