Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding relationship and credit card support #3

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

BaronWolfenstein
Copy link

These things are nice to have in the models when writing mindbody wrappers.

emergency contacts
match spec update for emergency info
adding relationship support
adding relationship support
adding relationship support
added credit card support
added credit card support
@wingrunr21
Copy link
Owner

Hi,

Thanks for adding this. I need a few things before merging:

  1. Travis build needs to be green
  2. All new models need specs
  3. Please rebase the commits into a few commits with informative commit messages.

Any questions let me know

@BaronWolfenstein
Copy link
Author

ok yeah, only the client has an incomplete spec atm. I'll get on that
tonight.

On Sat, Aug 31, 2013 at 5:32 PM, Stafford Brunk [email protected]:

Hi,

Thanks for adding this. I need a few things before merging:

  1. Travis build needs to be green
  2. All new models need specs
  3. Please rebase the commits into a few commits with informative commit
    messages.

Any questions let me know


Reply to this email directly or view it on GitHubhttps://github.com//pull/3#issuecomment-23616564
.

@BaronWolfenstein
Copy link
Author

Hmm, I have the client and client relationship models in a sort of circular
dependency.

Should I create a related_client model? But that would inherit from client
too. I guess the client in client relationship does not need client
relationships of its own, just the client tag to be parsed in the xml.

On Sat, Aug 31, 2013 at 5:33 PM, Noah Rahman [email protected] wrote:

ok yeah, only the client has an incomplete spec atm. I'll get on that
tonight.

On Sat, Aug 31, 2013 at 5:32 PM, Stafford Brunk [email protected]:

Hi,

Thanks for adding this. I need a few things before merging:

  1. Travis build needs to be green
  2. All new models need specs
  3. Please rebase the commits into a few commits with informative commit
    messages.

Any questions let me know


Reply to this email directly or view it on GitHubhttps://github.com//pull/3#issuecomment-23616564
.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 24380e4 on BaronWolfenstein:master into * on wingrunr21:master*.

@BaronWolfenstein
Copy link
Author

OK, I've been meanig to look into this with regard to their new API changes
that just went live

On Fri, Nov 21, 2014 at 11:42 AM, Coveralls [email protected]
wrote:

[image: Coverage Status] https://coveralls.io/builds/1509698

Changes Unknown when pulling 24380e4
24380e4
on BaronWolfenstein:master
into * on wingrunr21:master*.


Reply to this email directly or view it on GitHub
#3 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants