Custom fonts and button Icons, fixed a few Windows issues, fixed focus issues within the same widget #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed build errors from Travis Cl:
Error: found trailing spaces in the following files:
src/scrollbar.cpp:59:
src/scrollbar.cpp:61:
Error: found the following coding style problems:
src/widget.cpp:111: else if (contained && prevContained){
Error: braces should occur on the same line as the if/while/.. statement. Found issues in the following files:
src/scrollbar.cpp:31: {
src/scrollbar.cpp:47: {
src/scrollbar.cpp:68: {
src/scrollbar.cpp:77: {
src/scrollbar.cpp:88: {
src/scrollbar.cpp:121: {
src/scrollbar.cpp:152: {
The command "resources/check-style.sh" exited with 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theme.cpp
Modified themes to import fonts from a file rather than a resource, and tied font references in widgets to the theme rather than to sans-bold.
Widget.cpp:
Un-focus widgets when clicking outside them while being in the same parent.
Added childContainedAlready bool so only top child in the widget is focused