Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix timer #6

Merged
merged 5 commits into from
Dec 13, 2022
Merged

Attempt to fix timer #6

merged 5 commits into from
Dec 13, 2022

Conversation

ji-mmyliu
Copy link
Contributor

Change frontend timer calculations

@ji-mmyliu ji-mmyliu requested a review from nyiyui December 12, 2022 22:12
@ji-mmyliu
Fix time calculation
58ff750
@ji-mmyliu
Calculate time right away
032696c 
Define calculateTime() function for calculating remaining time. Call
this function at DOM initialization
@nyiyui
Copy link
Member

nyiyui commented Dec 13, 2022

Thank you (˘︶˘).｡.:*♡
I'll rebase and merge soon.

@nyiyui
Copy link
Member

nyiyui commented Dec 13, 2022

Merged via c9122e3.

@nyiyui nyiyui closed this Dec 13, 2022
@nyiyui nyiyui deleted the jl-timer branch December 13, 2022 05:02
@nyiyui nyiyui restored the jl-timer branch December 13, 2022 05:04
@nyiyui
Copy link
Member

nyiyui commented Dec 13, 2022

Oops. I didn't pull 032696c when rebasing.

@nyiyui nyiyui reopened this Dec 13, 2022
@nyiyui nyiyui merged commit dd1d8e5 into 2022 Dec 13, 2022
@nyiyui nyiyui mentioned this pull request Dec 13, 2022
Closed
@ji-mmyliu ji-mmyliu deleted the jl-timer branch December 13, 2022 22:21
@nyiyui nyiyui self-assigned this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyiyui nyiyui Awaiting requested review from nyiyui

Assignees

@nyiyui nyiyui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ji-mmyliu @nyiyui