-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incompatible notice in editor due missing style properties #3564
base: develop
Are you sure you want to change the base?
Conversation
Hi @wjrosa I see the incompatibility notice in one scenario. To reproduce-
|
Thanks, Mayisha! I am a bit lost here with this notice. I asked for @nielslange 's help since he introduced this feature. I hope he can give us some insights on how to fix this. |
@wjrosa Thanks for reaching out.
@Mayisha On your screenshot, I see empty bullet points. When trying to reproduce this issue on my end, I see the corresponding incompatible payment gateways: Can you tell me detailed steps to reproduce this issue? It might also be helpful if you could post your SSR. That way, I can see which versions you are using. As for seeing the incompatibility notice in general, I'd say that's expected when the site currency is set to USD, but the corresponding payment gateways expect the currency to be EUR. That said, the warning message "Some active extensions do not yet support this block." is not optimal. It might be better to change this warning message to something like "Some active extensions do not yet support this block or are incompatible with the cite currency." |
Fixes #3356
Related #3516
Changes proposed in this Pull Request:
This is an additional fix for the incompatibility notice issue being displayed on our editor. The original PR should fix the root cause, but this PR adds support for styles as an additional layer.
Testing instructions
fix/incompatible-notice-in-editor
)changelog.txt
andreadme.txt
(or does not apply)Post merge