Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatible notice in editor due missing style properties #3564

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Oct 30, 2024

Fixes #3356
Related #3516

Changes proposed in this Pull Request:

This is an additional fix for the incompatibility notice issue being displayed on our editor. The original PR should fix the root cause, but this PR adds support for styles as an additional layer.

Testing instructions

  • Checkout and build this branch on your test environment (fix/incompatible-notice-in-editor)
  • As a merchant, edit your Checkout page
  • Select the block checkout section
    Screenshot 2024-12-16 at 09 05 08
  • Confirm the notice is now gone
    Screenshot 2024-12-16 at 09 05 32

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

@wjrosa wjrosa self-assigned this Oct 30, 2024
@wjrosa wjrosa marked this pull request as ready for review December 16, 2024 12:06
@wjrosa wjrosa requested review from a team and mattallan and removed request for a team December 16, 2024 12:07
@mattallan mattallan requested review from a team and Mayisha and removed request for mattallan and a team December 18, 2024 03:29
@Mayisha
Copy link
Contributor

Mayisha commented Dec 19, 2024

Hi @wjrosa

I see the incompatibility notice in one scenario. To reproduce-

  • Set the store currency to USD.
  • In the Stripe settings page enable a few payment methods that support only Euro (iDeal, SEPA, EPS etc.)
  • Go to the edit checkout page.
  • Select the block checkout section.
Screenshot 2024-12-19 at 9 29 43 PM

@wjrosa
Copy link
Contributor Author

wjrosa commented Dec 20, 2024

Hi @wjrosa

I see the incompatibility notice in one scenario. To reproduce-

  • Set the store currency to USD.
  • In the Stripe settings page enable a few payment methods that support only Euro (iDeal, SEPA, EPS etc.)
  • Go to the edit checkout page.
  • Select the block checkout section.
Screenshot 2024-12-19 at 9 29 43 PM

Thanks, Mayisha! I am a bit lost here with this notice. I asked for @nielslange 's help since he introduced this feature. I hope he can give us some insights on how to fix this.

@nielslange
Copy link
Member

nielslange commented Dec 23, 2024

Thanks, Mayisha! I am a bit lost here with this notice. I asked for @nielslange 's help since he introduced this feature. I hope he can give us some insights on how to fix this.

@wjrosa Thanks for reaching out.

I see the incompatibility notice in one scenario. To reproduce-

  • Set the store currency to USD.
  • In the Stripe settings page enable a few payment methods that support only Euro (iDeal, SEPA, EPS etc.)
  • Go to the edit checkout page.
  • Select the block checkout section.

@Mayisha On your screenshot, I see empty bullet points. When trying to reproduce this issue on my end, I see the corresponding incompatible payment gateways:

Screenshot 2024-12-23 at 14 44 21

Can you tell me detailed steps to reproduce this issue? It might also be helpful if you could post your SSR. That way, I can see which versions you are using.

As for seeing the incompatibility notice in general, I'd say that's expected when the site currency is set to USD, but the corresponding payment gateways expect the currency to be EUR. That said, the warning message "Some active extensions do not yet support this block." is not optimal. It might be better to change this warning message to something like "Some active extensions do not yet support this block or are incompatible with the cite currency."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty incompatibility plugin registered with Checkout block
3 participants