-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Clearpay/Afterpay transaction limits information #3670
Merged
wjrosa
merged 9 commits into
develop
from
tweak/add-clearpay-afterpay-transaction-limit-info
Dec 19, 2024
Merged
Add Clearpay/Afterpay transaction limits information #3670
wjrosa
merged 9 commits into
develop
from
tweak/add-clearpay-afterpay-transaction-limit-info
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjrosa
commented
Dec 18, 2024
return sprintf( description, ...args ); | ||
const { description } = PaymentMethodsMap[ method ]; | ||
|
||
if ( method === PAYMENT_METHOD_AFFIRM ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am making the code more specific since this affects only Affirm.
wjrosa
requested review from
a team and
Mayisha
and removed request for
a team
December 18, 2024 15:59
…learpay-afterpay-transaction-limit-info
Mayisha
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Base automatically changed from
tweak/improving-affirm-method-display
to
develop
December 19, 2024 12:48
wjrosa
deleted the
tweak/add-clearpay-afterpay-transaction-limit-info
branch
December 19, 2024 13:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Clearpay/Afterpay has limits based on the Stripe account and the customer's country. You can check them here. This PR adds this information when listing the method along with the link.
Testing instructions
tweak/add-clearpay-afterpay-transaction-limit-info
)wp-admin/admin.php?page=wc-settings&tab=checkout§ion=stripe&panel=methods
)https://docs.stripe.com/payments/afterpay-clearpay#collection-schedule
)changelog.txt
andreadme.txt
(or does not apply)Post merge