Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clearpay/Afterpay transaction limits information #3670

Merged
merged 9 commits into from
Dec 19, 2024

Conversation

wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Dec 18, 2024

Changes proposed in this Pull Request:

Clearpay/Afterpay has limits based on the Stripe account and the customer's country. You can check them here. This PR adds this information when listing the method along with the link.

Testing instructions

  • Checkout and build this branch on your test environment (tweak/add-clearpay-afterpay-transaction-limit-info)
  • Go to the payment method listing page (wp-admin/admin.php?page=wc-settings&tab=checkout&section=stripe&panel=methods)
  • Confirm the new Clearpay/Afterpay method description and click the link to see if it goes to where it should (https://docs.stripe.com/payments/afterpay-clearpay#collection-schedule)
    Screenshot 2024-12-18 at 12 58 37

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

@wjrosa wjrosa self-assigned this Dec 18, 2024
return sprintf( description, ...args );
const { description } = PaymentMethodsMap[ method ];

if ( method === PAYMENT_METHOD_AFFIRM ) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am making the code more specific since this affects only Affirm.

@wjrosa wjrosa requested review from a team and Mayisha and removed request for a team December 18, 2024 15:59
@wjrosa wjrosa marked this pull request as ready for review December 18, 2024 15:59
Copy link
Contributor

@Mayisha Mayisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Both AfterPay/ClearPay and Affirm methods have the updated descriptions. 👍

Screenshot 2024-12-19 at 4 16 14 PM

Base automatically changed from tweak/improving-affirm-method-display to develop December 19, 2024 12:48
@wjrosa wjrosa merged commit 8342788 into develop Dec 19, 2024
33 of 35 checks passed
@wjrosa wjrosa deleted the tweak/add-clearpay-afterpay-transaction-limit-info branch December 19, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants