-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the dispute created message #3671
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjrosa
requested review from
a team and
Mayisha
and removed request for
a team
December 19, 2024 14:12
6 tasks
Mayisha
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wjrosa. I have added a little suggestion. Otherwise looks good to me 👍
Co-authored-by: Mayisha <[email protected]>
…com/woocommerce/woocommerce-gateway-stripe into fix/improve-dispute-created-message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1233
Changes proposed in this Pull Request:
Most times, when a dispute is open, no actions are needed. It is either already lost or won. The current note we add to the order implies that an action is always required. This PR fixes that by checking the dispute status and setting the note accordingly.
Testing instructions
Since this is a bit hard to test, code review should be enough. But if you want to try testing the flow:
fix/improve-dispute-created-message
)Sample event
"A dispute was created for this order. It was closed as lost or accepted."
changelog.txt
andreadme.txt
(or does not apply)Post merge