-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: direction enum order #265
base: main
Are you sure you want to change the base?
Conversation
errors should be handled and visible by the developer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests?
sure, I will add later |
this pr does much more than add tests for my changes, it is also setup the integration testing with mongo in memory, and the setup not working, its not connecting the database in memory, that's why it didn't merge before I don't know how to solve it, I think it's better to revert to fist commit and setup integration tests in other pr and too, other changes were made in period this pr, and when I merge, other tests broke |
No description provided.