Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: direction enum order #265

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

fix: direction enum order #265

wants to merge 11 commits into from

Conversation

Tsugami
Copy link

@Tsugami Tsugami commented Nov 9, 2021

No description provided.

errors should be handled and visible by the developer
Copy link
Member

@sibelius sibelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests?

@Tsugami
Copy link
Author

Tsugami commented Nov 9, 2021

tests?

sure, I will add later

@Tsugami Tsugami marked this pull request as draft November 9, 2021 22:11
@Tsugami Tsugami requested a review from sibelius November 13, 2021 07:11
@italosantana
Copy link

@Tsugami Did you finish the tests or or are you going to add more for @sibelius to review later?

@Tsugami
Copy link
Author

Tsugami commented Apr 21, 2022

@Tsugami Did you finish the tests or or are you going to add more for @sibelius to review later?

It's been a long time, from what I've read, I wrote the tests, I don't remember why I didn't take the pr from the draft, I'll fix the conflicts and run the tests here to see its ok

@Tsugami
Copy link
Author

Tsugami commented Apr 22, 2022

this pr does much more than add tests for my changes, it is also setup the integration testing with mongo in memory, and the setup not working, its not connecting the database in memory, that's why it didn't merge before

I don't know how to solve it, I think it's better to revert to fist commit and setup integration tests in other pr

and too, other changes were made in period this pr, and when I merge, other tests broke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants