[BE] SSE 기반 타이머 잔여 시간 조회 기능을 Web Socket 기반으로 변경 #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yechop
reviewed
Nov 20, 2024
|
|
||
| public class EmptyQueryException extends WebSocketException { | ||
|
|
||
| public EmptyQueryException(String message) { |
…961 # Conflicts: # backend/src/test/java/site/coduo/websocket/QueryAccessCodeParserTest.java
reddevilmidzy
requested changes
Nov 20, 2024
Comment on lines
+5
to
+6
| public record EventAndDataMessage(String event, String data) implements WebSocketMessage { | ||
| } |
There was a problem hiding this comment.
WebSocketMessage 를 인터페이스로 두고 이 EventAndDataMessage를 레코드로 설계하신 이유가 궁금합니다!
There was a problem hiding this comment.
WebSocketMessage는 타이머, 레퍼런스 링크, 투두 에서 사용될 예정입니다.
현재 타이머엔 event와 data 만 필요하지만 도메인이나 상황에 따라 다양한 필드를 가진 WebSocketMessage들이 필요할 수 있어� 추상화 했습니다.
There was a problem hiding this comment.
아하 인터페이스를 레코드로 구현하는게 신기(?)해서 남긴 질문이였어요
지금 인터페이스는 뭔가 데이터 모음을 한번에 처리하기 위한 그런 역할이군요
| @DisplayName("accesscode가 비어있으면 예외가 발생한다.") | ||
| @Test | ||
| void throwExceptionWhenAccessCodeIsEmpty() { | ||
| String query = "user=ink&accesscode="; |
yechop
force-pushed
the
BE/feature/#961
branch
from
68f5f52
to
ada435c
Compare
yechop
approved these changes
Nov 21, 2024
JiHyeonL
approved these changes
Nov 23, 2024
reddevilmidzy
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관된 이슈
구현한 기능
상세 설명