Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Update Dangerfile to run Rubocop with bundle exec #23854

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

iangmaia
Copy link
Contributor

As the title says.

This is a change related to an update in the Linter CI Agent to make sure Rubocop is run with bundle exec.

Testing

CI should be 🟢

@iangmaia iangmaia added the Tooling Build, Release, and Validation Tools label Nov 21, 2024
@iangmaia iangmaia requested a review from a team November 21, 2024 22:01
@iangmaia iangmaia self-assigned this Nov 21, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 21, 2024

1 Warning
⚠️ This PR is assigned to the milestone 25.5. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@iangmaia iangmaia added this to the 25.5 milestone Nov 21, 2024
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 21, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23854-5fb5946
Version25.4.2
Bundle IDorg.wordpress.alpha
Commit5fb5946
App Center BuildWPiOS - One-Offs #11118
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 21, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23854-5fb5946
Version25.4.2
Bundle IDcom.jetpack.alpha
Commit5fb5946
App Center Buildjetpack-installable-builds #10158
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@iangmaia iangmaia force-pushed the iangmaia/use-rubocop-from-bundle branch from fb42dc7 to ab475cc Compare November 22, 2024 00:19
@iangmaia iangmaia force-pushed the iangmaia/use-rubocop-from-bundle branch from ab475cc to 5fb5946 Compare November 22, 2024 00:41
@iangmaia iangmaia added this pull request to the merge queue Nov 22, 2024
Merged via the queue into trunk with commit 63a60a6 Nov 22, 2024
24 checks passed
@iangmaia iangmaia deleted the iangmaia/use-rubocop-from-bundle branch November 22, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tooling Build, Release, and Validation Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants