Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(world-chain-builder): Clean up comments #69

Merged
merged 1 commit into from
Nov 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions world-chain-builder/src/pbh/db.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,14 @@ use bytes::BufMut;
use reth_db::cursor::DbCursorRW;
use reth_db::mdbx::tx::Tx;
use reth_db::mdbx::{DatabaseArguments, DatabaseFlags, RW};
use reth_db::{create_db, DatabaseError};
use std::path::Path;
use std::sync::Arc;
// TODO: maybe think about some sort of data retention policy for PBH transactions.
use reth_db::table::{Compress, Decompress, Table};
use reth_db::transaction::DbTxMut;
use reth_db::{create_db, DatabaseError};
use revm_primitives::{FixedBytes, B256};
use semaphore::Field;
use serde::{Deserialize, Serialize};
use std::path::Path;
use std::sync::Arc;
use tracing::info;

/// Table to store PBH validated transactions along with their nullifiers.
Expand Down
10 changes: 5 additions & 5 deletions world-chain-builder/src/pool/noop.rs
Original file line number Diff line number Diff line change
Expand Up @@ -251,35 +251,35 @@ impl TransactionPool for NoopWorldChainTransactionPool {
&self,
_hashes: Vec<TxHash>,
) -> Vec<Arc<ValidPoolTransaction<Self::Transaction>>> {
vec![] //TODO: implement
vec![]
}

fn remove_transactions_by_sender(
&self,
_sender: Address,
) -> Vec<Arc<ValidPoolTransaction<Self::Transaction>>> {
vec![] //TODO: implement
vec![]
}

fn get_queued_transactions_by_sender(
&self,
_sender: Address,
) -> Vec<Arc<ValidPoolTransaction<Self::Transaction>>> {
vec![] //TODO: implement
vec![]
}

fn get_pending_transactions_by_sender(
&self,
_sender: Address,
) -> Vec<Arc<ValidPoolTransaction<Self::Transaction>>> {
vec![] //TODO: implement
vec![]
}

fn get_highest_consecutive_transaction_by_sender(
&self,
_sender: Address,
_on_chain_nonce: u64,
) -> Option<Arc<ValidPoolTransaction<Self::Transaction>>> {
None //TODO: implement
None
}
}