Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Electron 33 #1234

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Upgrade to Electron 33 #1234

wants to merge 26 commits into from

Conversation

karaggeorge
Copy link
Member

@karaggeorge karaggeorge commented Oct 20, 2024

This upgrades to Electron 33:

  • Refactored all usages of remote to use ipc instead
  • Refactored around some deprecated APIs

Known broken things that were not migrated:

  • App icons in the cropper are not working
  • Editor video is not centered
  • Editor window traffic lights are broken
  • Editor title bar has to stay down at all times (not show on hover) because of new -webkit-app-region: drag; limitations

I tried to upgrade as few packages as possible. I have another branch that upgrade all our utils, but we need to upgrade the entire project to use ESM (type: "module"). I did do that, but then the renderer Next.js app is not working. I tried upgrading Next.js and getting that to work, but electron-next was not working with it 🙈

Overall, we still have .js code, class components, in-line styled jsx and a lot of other really outdated code
I think we need to move away from electron-next and Next.js, and just have a regular webpack build (or vite) for the renderers

Also, a lot of code needs to be re-written to improve performance, especially the cropper

Copy link
Collaborator

@albinekb albinekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants