Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Fibre Channel (FC) to list of supported storage types #293

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

thomas-dkmt
Copy link
Collaborator

As requested by Jon

Before submitting the pull request, you must agree with the following statements by checking both boxes with a 'x'.

  • "I accept that my contribution is placed under the CC BY-SA 2.0 license [1]."
  • "My contribution complies with the Developer Certificate of Origin [2]."

[1] https://creativecommons.org/licenses/by-sa/2.0/
[2] https://docs.xcp-ng.org/project/contributing/#developer-certificate-of-origin-dco

@@ -59,7 +59,7 @@ There are storage types that are officially supported, and others that are provi
<td>XOSTOR</td>
<td>X</td>
<td>X</td>
<td>Soon</td>
<td>X</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: it's supported in XCP-ng 8.2, not in XCP-ng 8.3 yet.

@Danp2
Copy link
Collaborator

Danp2 commented Nov 5, 2024

Isn't fibre channel already covered by hba?

@stormi
Copy link
Member

stormi commented Nov 5, 2024

Isn't fibre channel already covered by hba?

I thought so, but @Fohdeesha said that an entry is missing for Fibre Channel and my knowledge of HBA and FC is so limited that I didn't object.

@stormi stormi requested a review from Fohdeesha November 5, 2024 10:43
@Fohdeesha
Copy link
Member

@Danp2 HBA and fibrechannel are two very different SR types/storages, HBA is plain HBAs presenting SAS connections with no networking possible, fibrechannel is LVM over actual fibrechannel networks. We've already had one customer asking why we don't support FC because they couldn't find it in the feature matrix this PR is covering

Copy link
Member

@Fohdeesha Fohdeesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Member

@stormi stormi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me if the need is urgent, else I'd wait for an additional commit adding the missing Fibre Channel section in the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants