-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document CPU limits and other limits of VMs in XCP-ng #296
base: master
Are you sure you want to change the base?
Conversation
d6935a6
to
70a9b30
Compare
Looks good, only 2 questions/suggestions. |
Adding @olivierlambert and @julien-f to the reviewers as the topic of what we say we support or not is a product management topic IMO. |
Why is there a modified version of my already merged "Add doc related to Nested Virtualization, and update 8.3 release notes" commit in this PR? |
@thomas-dkmt Ensure your |
b63429c
to
877b586
Compare
c6940b8
to
156cfe1
Compare
There still is a problem with this branch. It looks like a rebase it still needed. |
Nitpicking about the commit messages: the convention in commit messages is usually to use the imperative form rather than the past tense. For example "Improved the style and presentation across the whole page" would become "Improve the style and presentation across the whole page". |
156cfe1
to
dc6dd17
Compare
Rebase done |
dc6dd17
to
53e1ad1
Compare
Signed-off-by: Thomas Moraine <[email protected]>
Signed-off-by: Thomas Moraine <[email protected]>
Signed-off-by: Thomas Moraine <[email protected]>
Signed-off-by: Thomas Moraine <[email protected]>
6648ab3
to
88ed53b
Compare
Signed-off-by: Thomas Moraine <[email protected]>
docs/installation/requirements.md
Outdated
- FreeBSD and related distributions (e.g., pfSense, TrueNAS) | ||
- OpenBSD | ||
|
||
## Virtual Machine Requirements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure at all with this entire section:
- we are very cautious and a quick overview isn't great for us by looking at the numbers
- We tested more than 64 vCPU with some Linux VMs IIRC, and topology will be one important work next year. So if we provide a limit, we should always put that in perspective with actual work
- it's even worse for the 2TiB limit, which isn't true for all VDI. Raw are not limited, SMAPIv3 current drivers neither and we aren't far to get qcow2 on tapdisk. So to me it's simply too negative to restrict too much by displaying those numbers without context.
- I'm not aware of a CD drive limit per VM, I remember some XS doc explaining how to add another one
- I'm not even sure about some limits (only one passed through GPU? never heard of it)
The rest of the PR is OK to me. Maybe we can start to merge everything except the VM limits which require more work to be suitable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to address all this in a new commit. We're not in a hurry to merge this PR so I think we can take the time to finalize it as a whole.
Mention how to go beyond some limits when some trade-offs are acceptable. Remove some not essential limits we are unsure about at the moment. Signed-off-by: Samuel Verschelde <[email protected]>
Ping @olivierlambert whenever you find time |
I’ve updated the Requirements page of the XCP-ng documentation, so that it includes the VM limits (CPU, Network, vGPU, etc.), and I improved the overall style and language.