-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests against different activerecord/activesupport versions #109
Conversation
The issue to use this commit was fixed with thoughtbot/appraisal@ea2baff
To lessen the load, I also switched from appraisal install to appraisal generate and then only install gems for a given generated gemfile, not for all of them.
…or faster results" go is needed to create beetle binary, that is then used for cucumber tests This reverts commit d127a7b.
…d in docker compose up step
… provided in docker compose up step" Yes we do for beetle binary tests This reverts commit 4c10ddc.
@danielgoncharov @david-krentzlin what do you think of this? Not sure about the cost side, with additional checks against activerecord versions we would end up with 3 * 2 * 4 = 24 checks eventually. |
@Aqualon Yeah, I think it is a good idea and since they should run in parallel I see no problem at all. Wondering if we want this for |
It would also not increase the number of combinations, since they should come with the same version. @Aqualon What do you think? |
|
Ah, yeah true. I would make it explicit, and do it as you said. Define the ruby version and then add |
@jojahner if it's fine for you, please approve/merge it. I'd then open another PR for the 7.2.0 adaptations |
Cool, thank you! ❤️ |
Currently tests don't run against different activerecord versions, but just assumed everything is like in activerecord 5.
43 different activerecord versions[6.1.7.8, 7.0.8.4, 7.1.3.4]
(7.2.0
fails currently, so would only enable it together with the fix)Can we move out the go tests, since they are independent of the ruby/redis/activerecord matrix? Currently they run on all of themwe can't, because failover tests require beetle binary created in the go step