Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use true and false for ssl option #110

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

jojahner
Copy link
Contributor

@jojahner jojahner commented Aug 19, 2024

Bunny actually uses true and false for the ssl setting: https://github.com/ruby-amqp/bunny/blob/0.7.12/lib/qrack/client.rb#L51.

This PR changes the behavior to also use true and false for the ssl configuration. It also, instead of passing ssl: nil to Bunny#new, now defaults to ssl: false if the option is not set.

Copy link
Contributor

@danielgoncharov danielgoncharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jojahner
Copy link
Contributor Author

Yeah, I will adapt it.

Copy link
Contributor

@danielgoncharov danielgoncharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images

@jojahner jojahner merged commit 665ddcc into v4.x Aug 20, 2024
6 checks passed
@jojahner jojahner deleted the use_correct_value_for_ssl branch August 20, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants