Plist settings over UserDefaults #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasThomas
reviewed
Jan 8, 2018
| @@ -36,10 +36,14 @@ class SettingsViewController: NSViewController { | |||
| (linkField4, linkDescriptionField4) | |||
| ] | |||
|
|
|||
| if let cucumberProfile = applicationStateHandler.cucumberProfile { | |||
| if let cucumberProfile = plistOperations.readValues(forKey: Constants.Keys.cucumberProfileInfo).first { | |||
There was a problem hiding this comment.
What about keeping this logic in the ApplicationStateHandler?
There was a problem hiding this comment.
I also wanted to do so, but then decided to do not, as if some users already saved this value in their settings, the next run will explicitly give them a warning asking to add the profile with available options.
There was a problem hiding this comment.
I don't get that? What I mean is that you can just do applicationStateHandler.cucumberProfile in which internally (so in the StateHandler) it does readValues instead of reading from UserDefaults.
There was a problem hiding this comment.
#128 has been created to tackle this 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respect plist settings over UserDefaults