Some fix on definitions #155
Conversation
There was a problem hiding this comment.
Hi, thank you for contributing to SaintCoinach.
This PR comes with no context, 6.2 references in commit messages that are up to 8 months old, doesn't follow naming conventions and contains half the changes that are wrong, please make sure to add context to the PR using the PR's message and make sure your PR contains updates that are valid, because checking every single edit is really not fun.
| @@ -30,9 +30,9 @@ | |||
| } | |||
| }, | |||
| { | |||
| "index": 18, | |||
| "index": 19, | |||
There was a problem hiding this comment.
Data shows that it's starting at 18 and repeats for 5, not 4 (I included 18 in the example below)
There was a problem hiding this comment.
for Deep Dungeon sheet
col 18: offset 28
col 19: offset 16
col 20: offset 17
col 21: offset 18
col 18 is used in
ffxiv_dx11.exe ver. 2023.07.26.0000.0000: 140A637E6
which is not a list of data but a type enum
There was a problem hiding this comment.
Then what's col 18? Did you check against ingame data as you're in deep dungeon?
There was a problem hiding this comment.
Then what's col 18? Did you check against ingame data as you're in deep dungeon?
it seems a flag to identicate which type of sheet is for idx 19-22, just look at the full function, if this flag is 1, DeepDungeonMagicStone is used and when the flag is 2, DeepDungeonDemiclone is used.
There was a problem hiding this comment.
I'm not really doing exe digging to update definitions, it's just based on what it's matching ingame as we compare data and UI.
There was a problem hiding this comment.
It means that you should implement it as a complexlink for col 18 then, better do it in this PR.
Here is an example of a complexlink:
SaintCoinach/SaintCoinach/Definitions/Achievement.json
Lines 63 to 71 in 2f894d7
No description provided.