Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Island data #158

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Island data #158

merged 2 commits into from
Oct 2, 2023

Conversation

kaydeethree
Copy link
Contributor

Name/link a few fields

@kaydeethree
Copy link
Contributor Author

One link I can't figure out how to make is that MJIGatheringItem#2 is MJIKeyItem#1 (what I've called "Sort" in this PR)

this commit adds more of the gathering tool connection but it's not resolving MJIGatheringTool properly in MJIGatheringItem
@Supamiu
Copy link
Contributor

Supamiu commented Sep 30, 2023

Hi, thanks for your contribution 🙂

I'm not sure I understand what you mean by "MJIGatheringItem#2 is MJIKeyItem#1", can you explain a bit more with example screenshots if possible?

@kaydeethree
Copy link
Contributor Author

Please disregard the initial comment. With the current PR state, this is what MJIGatheringItem looks like. image

This is despite that fact that MJIGatheringTool looks like this:
image

@Supamiu
Copy link
Contributor

Supamiu commented Oct 1, 2023

I see, this is just because Saint doesn't find how to represent this by string so it just puts a link like what you're seeing. I assume because it's too deep (to get the string, you'd have to read the MJIGatheringTool row, then read the associated Item row, then grab the string in the Name column).

If you're willing to use this data, I highly suggest using either SaintCoinach directly (as a .Net dependency) or Lumina (same, available in NuGet iirc). Or parsing the CSV to resolve the link by yourself.

Anyways, adding defaultColumn set to

@kaydeethree
Copy link
Contributor Author

Oh I'm already parsing the CSVs. Just trying to contribute my knowledge back to the community.

Your comment cut off. What's defaultColumn?

@Supamiu
Copy link
Contributor

Supamiu commented Oct 1, 2023

Oh I just forgot to remove that line, defaultColumn is already set for MJIGatheringTool

@kaydeethree
Copy link
Contributor Author

Alright. Any other changes needed to pass review / merge?

@Supamiu
Copy link
Contributor

Supamiu commented Oct 2, 2023

I think we're good to go 🙂

@Supamiu Supamiu merged commit 863c1ce into xivapi:master Oct 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants