-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#43: Fix pytorch install #48
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is better approach than #44 given the explicit choice between the two systems (mac or other)
With the suggested code
I am getting
I tried quite a bit but in the end I cannot install PyTorch on Mac from If you dislike the verbose sys_platform or machine_... syntax, then this here did work on my Mac, too. Did not test again on Ubuntu, though.
|
Thanks for telling me this, i was hoping that in MacOS that poetry would switch to the non-cuda version of torch. I'll test it out now |
We can probably do that change, but will ignore CPU users in other platforms. Might be reasonable for now until we can figure out how to make install CPU torch by default then just do a flag (e.g |
shrek is gonna switch from poetry to uv soon |
Allows install of either pytorch w/ cuda or plain pytorch and also fixes this error: