Refactor runner.py #830
Merged
Refactor runner.py #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| params["MAX_ABS_ERROR"] = MAX_ABS_ERROR | ||
| params["ABS_AVG_ERROR"] = ABS_AVG_ERROR | ||
| params["AVG_ABS_ERROR"] = AVG_ABS_ERROR | ||
| params["REQUIRED_OUTPUTS"] = REQUIRED_OUTPUTS | ||
| yaml_filename = os.path.join(os.path.dirname(model_path), "params.yaml") |
There was a problem hiding this comment.
Why are we loading from yaml here?
|
|
||
| # some models are special (such as detection_postprocess), they don't have | ||
| # a reference int8 TFLite operator and need to be loaded separately | ||
| special_path = model_path.parent.joinpath("special.tflite.xc") |
There was a problem hiding this comment.
This seems strange as we are not doing it only for detection_postprocess. Is the idea that if there is a special tflite, always load that instead?
|
@michaelpoluektov I like the changes, it looks cleaner. Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TFLMC wasn't added yet because I couldn't manage to get it to work. It would be implemented as another AbstractRunner