[Fix] Name generalization of transformer blocks #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the name of a transformer block (start and end nodes) can follow the pattern model_layers_X (for mistral) or transformer_h_X we must generalize it. Co-Authored-By: Daniel Grittner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @danielgrittner pointed out, some models can have different naming conventions but follow the same pattern, this pr fixes the issue by using the base_model_prefix and finding the transformer block name, instead of always using transformer_h_X.
Tests work the same as they did, as this doesn't affect the workings of the partitioning, we just are generalizing the way to identify transformer blocks.