xvariable_masked_view should inherit from xvariable_base #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
force-pushed
the
xmasked_view_variable_base
branch
from
e874fa5 to
c4172c0
Compare
martinRenou
changed the title
|
Not only it removes a lot of code, but it also helped me to found a bug in the |
martinRenou
commented
Jan 18, 2019
JohanMabille
requested changes
Jan 21, 2019
martinRenou
changed the title
martinRenou
force-pushed
the
xmasked_view_variable_base
branch
from
c4172c0 to
35f2c0f
Compare
JohanMabille
approved these changes
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.