Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix xmasked_view with xfunction #2501

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix xmasked_view with xfunction #2501

wants to merge 3 commits into from
+27 −8

Conversation

gouarin
Copy link
Member

@gouarin gouarin commented Mar 28, 2022 •
edited
Loading

Checklist

  • The title and commit message(s) are descriptive.
  • Small commits made to fix your PR have been squashed to avoid history pollution.
  • Tests have been added for new features or bug fixes.
  • API of new functions and classes are documented.

Description

@tdegeus
Copy link
Member

tdegeus commented Apr 26, 2022

@gouarin I'm not a big expert here so I cannot estimate what it takes to fix this. A question though: Should be aim to include this in the next release.

@gouarin
Copy link
Member Author

gouarin commented Apr 26, 2022

I fixed the first issue but a new one appears. I had a discussion with @JohanMabille about that and it's not so easy to fix it.
We will take time together to find a solution after his vacation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gouarin @tdegeus