Manule style fixes #2642
Merged
Manule style fixes #2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to be some GH bug with the CI... |
JohanMabille
approved these changes
Jan 17, 2023
|
The failure with openmp is due to a concurrency issue in the xtl. The The failure on appveyor is weird, the CI did not start and I don't have any log. Anyway, we should migrate to GHA at some point. |
|
It would be good to switch indeed. I'm worked on a grant until Feb. 1 but thereafter I'm planning to do a bit of cleaning up here too, I also have some longstanding weird small bugs in a bit exotic that I need to solve. Furthermore, I think that we should decide on a timeframe to switch to C++17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Fixes #2637
Fixes #2632
Fixes #2633