-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to specify the path of the error file #195
base: master
Are you sure you want to change the base?
Conversation
Nevermind, that idea didn't work that well. The error file can actually get pretty big when there are a lot of errors in the input file. If we try to read and print that those errors, they can actually slow down the So, to keep the changes simple, I think my current approach to use the BCP parameter |
looks good, can you please add some unit test |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
I added 2 unit tests, one for the |
Let's split up the 2 unrelated issues, the SSL with ODBC 18, and your proposed change, can you make a new PR with just the SSL change? Also we use |
Gotcha. I reverted the changes that add the |
This change enables the use of the
-e
option forbcp
(https://learn.microsoft.com/en-us/sql/tools/bcp-utility?view=sql-server-ver16#-e-err_file). This allows the creation of error files that contain detailed information about the rows that thebcp
command couldn't process for whatever reason when executed.Also included is a change to the
bcp_path
param typing to add thepathlib.Path
type just because thebcp()
function already allows it.