Merge pull request mrdoob#16929 from Mugen87/dev35

TransformControls: Align .attach() method to Object3D.
yeticgi · Jun 30, 2019 · d713b77 · d713b77
2 parents 2ac4def + a4fbf22
commit d713b77
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/examples/js/controls/TransformControls.js b/examples/js/controls/TransformControls.js
@@ -142,6 +142,8 @@ THREE.TransformControls = function ( camera, domElement ) {
 		this.object = object;
 		this.visible = true;
 
+		return this;
+
 	};
 
 	// Detatch from object
@@ -151,6 +153,8 @@ THREE.TransformControls = function ( camera, domElement ) {
 		this.visible = false;
 		this.axis = null;
 
+		return this;
+
 	};
 
 	// Defined getter, setter and store for a property

diff --git a/examples/jsm/controls/TransformControls.d.ts b/examples/jsm/controls/TransformControls.d.ts
@@ -29,7 +29,7 @@ export class TransformControls extends Object3D {
   visible: boolean;
 
   attach(object: Object3D): this;
-  detach(): void;
+  detach(): this;
   pointerHover(pointer: Object): void;
   pointerDown(pointer: Object): void;
   pointerMove(pointer: Object): void;

diff --git a/examples/jsm/controls/TransformControls.js b/examples/jsm/controls/TransformControls.js
@@ -167,6 +167,8 @@ var TransformControls = function ( camera, domElement ) {
 		this.object = object;
 		this.visible = true;
 
+		return this;
+
 	};
 
 	// Detatch from object
@@ -176,6 +178,8 @@ var TransformControls = function ( camera, domElement ) {
 		this.visible = false;
 		this.axis = null;
 
+		return this;
+
 	};
 
 	// Defined getter, setter and store for a property