BBQ JS fix prototype pollution #4571
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will await cowboy/jquery-bbq#65 before reviewing this. |
You will probably be waiting forever which is why we bypassed them in the first place.
|
|
Perhaps, but even without merge at least there might be reviewers or commenters. I don't want to release too soon since this fix does not seem highly critical. I'll set a reminder to revisit this PR in case it takes too long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the previous fix for BBQ JS prototype pollution (#4570) with a new fix based on the upstream master branch (https://github.com/cowboy/jquery-bbq). This fix addresses only this one issue with a backward compatible fix (return value is always an object).
You will notice that there are bunch of URLs changed from https and http and IE support has been re-added. This brings it back in line with the current state of the upstream master.
A PR has been created on the upstream master to apply the same fix: cowboy/jquery-bbq#65