H5vccPlatformService #4471
Open
H5vccPlatformService #4471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongqiliang
requested review from
yell0wd0g,
johnxwork,
jasonzhangxx and
kaidokert
and removed request for
yell0wd0g and
johnxwork
johnxwork
reviewed
Nov 22, 2024
| mShellManager.launchShell(shellUrl); | ||
|
|
||
| // Load an empty page to let shell create WebContents. | ||
| mShellManager.launchShell(""); |
There was a problem hiding this comment.
Is there a more graceful way to do the init? You could add a TODO and leave the idea?
There was a problem hiding this comment.
This is the right way to do it. Alternatively, we will need to add code in content shell package here. https://source.chromium.org/chromium/chromium/src/+/main:content/shell/browser/shell.cc;l=230;drc=5d0194cbc9cddc2ad096da32f16d7d1eac5d4a34
| @@ -14,16 +14,20 @@ | |||
|
|
|||
| package dev.cobalt.coat; | |||
|
|
|||
| import static dev.cobalt.util.Log.TAG; | |||
| // import static dev.cobalt.util.Log.TAG; | |||
There was a problem hiding this comment.
Are we able to remove these commented code?
There was a problem hiding this comment.
We could, but I prefer leave it here, because it is needed for platform service asynchronize response, I will uncomment it in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a few critical changes.
b/379731250
b/379184982
b/378571210