JavaBridge Implementation of H5vccPlatformService #4517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongqiliang
force-pushed
the
h5vcc_phase_1_review_2
branch
6 times, most recently
from
9a5151e
to
3866d4f
Compare
It fixed the race condition of injecting the java bridge object and loading the url from shell. The pattern to polyfill the embeded javascript in the APK binary before Kabuki loads won't work, see context on b/379731250, as a result, we will move the javascript file chrobalt_preload.js and its sub modules on to Kabuki codebase. We will create a backlog bug for this when it is submitted. ClientLogInfo is used to test H5vccPlatformService. b/379731250 b/379184982 b/378571210
zhongqiliang
force-pushed
the
h5vcc_phase_1_review_2
branch
from
3866d4f
to
7170e9f
Compare
zhongqiliang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/379731250
b/379184982
b/378571210