Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor opa filter tests to use specific rules #3313

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Pushpalanka
Copy link
Collaborator

@Pushpalanka Pushpalanka commented Nov 18, 2024

Changes

  • Rego rules are made specific to test scenarios whenever it matters.
  • A new test is added to confirm fragment is ignored from HTTP request path.

Pending : HTTP2 headers are not tested as of yet. An internal ticket is present to address this.

@Pushpalanka Pushpalanka marked this pull request as ready for review November 25, 2024 12:08
@Pushpalanka Pushpalanka added enhancement minor no risk changes, for example new filters labels Nov 25, 2024
@Pushpalanka Pushpalanka force-pushed the refactor-opa-tests branch 2 times, most recently from 9d23b10 to 85dbae0 Compare December 3, 2024 13:11
@Pushpalanka Pushpalanka force-pushed the refactor-opa-tests branch 4 times, most recently from add7c43 to e0bea8e Compare December 6, 2024 16:58
@Pushpalanka Pushpalanka changed the title Refactor opa authorize request filter tests categorized based on http request components Refactor opa filter tests to use specific rules Dec 6, 2024
@Pushpalanka Pushpalanka force-pushed the refactor-opa-tests branch 2 times, most recently from 68a0251 to 6ebdb9e Compare December 6, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement minor no risk changes, for example new filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants