Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): regroup benchmark pages [WIP] #1429

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

yuxizama
Copy link
Contributor

Following Rand's suggestion, I grouped all existing benchmarks under the "Benchmark" page in "Get Started"

I think there are some updates to do, or new benchmarks to be added (compression?), it can be done on this basis.

@yuxizama yuxizama changed the title chore(docs): regroup benchmark pages chore(docs): regroup benchmark pages [WIP] Aug 7, 2024
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not clear on what was wanted in terms of data display but it looks like we are currently embedding tables which are not related to a specific version of TFHE-rs, I don't think I'm a fan because we need to maintain several sources of data

@IceTDrinker IceTDrinker force-pushed the doc-merge-benchmarks-pages branch 4 times, most recently from 757a405 to 7ec22b3 Compare September 26, 2024 15:45
@IceTDrinker IceTDrinker merged commit 576bc57 into main Sep 30, 2024
32 of 33 checks passed
@IceTDrinker IceTDrinker deleted the doc-merge-benchmarks-pages branch September 30, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants