Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(integer): improve {overflowing_}scalar_add/sub #1430

Merged
merged 1 commit into from
Aug 14, 2024
Merged

feat(integer): improve {overflowing_}scalar_add/sub #1430

merged 1 commit into from
Aug 14, 2024

Conversation

tmontaigu
Copy link
Contributor

@tmontaigu tmontaigu commented Jul 26, 2024 •
edited
Loading

  • check benches
  • handles trivial oveflow (scalar > ciphertext max)
  • modifiy test to use non fixed number of blocks
  • remove commented code
  • add some docs

@cla-bot cla-bot bot added the cla-signed label Jul 26, 2024
@tmontaigu tmontaigu force-pushed the tm/faster-scalar-add branch 2 times, most recently from 4136e60 to 300cc68 Compare July 29, 2024 14:35
@cla-bot cla-bot

This comment was marked as resolved.

Sign in to view
@cla-bot cla-bot bot removed the cla-signed label Jul 29, 2024
@cla-bot cla-bot bot added the cla-signed label Jul 29, 2024
@tmontaigu tmontaigu force-pushed the tm/faster-scalar-add branch 6 times, most recently from 9b23894 to bdfdc9c Compare August 1, 2024 12:49
@tmontaigu tmontaigu marked this pull request as ready for review August 1, 2024 14:23
nsarlin-zama
nsarlin-zama reviewed Aug 8, 2024
View reviewed changes
Copy link
Contributor

@nsarlin-zama nsarlin-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small comments, but awesome work !

tfhe/src/integer/server_key/radix_parallel/scalar_add.rs Show resolved Hide resolved
tfhe/src/integer/server_key/radix_parallel/add.rs Outdated Show resolved Hide resolved
tfhe/src/integer/server_key/radix_parallel/add.rs Outdated Show resolved Hide resolved
tfhe/src/integer/server_key/radix_parallel/add.rs Outdated Show resolved Hide resolved
tfhe/src/integer/server_key/radix_parallel/add.rs Outdated Show resolved Hide resolved
tfhe/src/integer/server_key/radix_parallel/add.rs Outdated Show resolved Hide resolved
tfhe/src/integer/server_key/radix_parallel/scalar_add.rs Outdated Show resolved Hide resolved
@tmontaigu tmontaigu force-pushed the tm/faster-scalar-add branch 3 times, most recently from e681f9a to 1d30b55 Compare August 12, 2024 09:54
@zama-bot zama-bot removed the approved label Aug 13, 2024
@tmontaigu
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot
Copy link

cla-bot bot commented Aug 14, 2024

The cla-bot has been summoned, and re-checked this pull request!

@tmontaigu tmontaigu merged commit 9413d3e into main Aug 14, 2024
85 checks passed
@tmontaigu tmontaigu deleted the tm/faster-scalar-add branch August 14, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsarlin-zama nsarlin-zama nsarlin-zama approved these changes

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmontaigu @nsarlin-zama @zama-bot