feat(gpu): implement ilog2, trailing and leading zeros and ones on GPU #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnesLeroy
reviewed
Aug 8, 2024
There was a problem hiding this comment.
Thanks a lot @guillermo-oyarzun! I made a first review, we'll have to check if the CI passes as there are quite many changes... 🙂
guillermo-oyarzun
force-pushed
the
go/feature/implement-leading-trailing-zeros-and-ones
branch
from
d2837c0
to
267ddd8
Compare
agnesLeroy
approved these changes
Aug 9, 2024
agnesLeroy
deleted the
go/feature/implement-leading-trailing-zeros-and-ones
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/zama-ai/tfhe-rs-internal/issues/514
PR content/description
Check-list: