Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: comparison less or equal then #1775

Closed
wants to merge 1 commit into from

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Nov 13, 2024

PR content/description

There was an equality sign missing in the scalar comparisons.

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

Copy link

cla-bot bot commented Nov 13, 2024

Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @Tuditi on file. In order for us to review and merge your code, please sign:

  • For individual contribution: our CLA
  • for Bounty submission, if you are an individual: our T&C
  • for Bounty submission, if you are a company: our T&C
    to get yourself added.

If you already signed one of this document, just wait to be added to the bot config.

@aquint-zama
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Nov 13, 2024
Copy link

cla-bot bot commented Nov 13, 2024

The cla-bot has been summoned, and re-checked this pull request!

Copy link

cla-bot bot commented Nov 13, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tuditi.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot bot removed the cla-signed label Nov 13, 2024
@zama-ai zama-ai deleted a comment from sonarcloud bot Nov 13, 2024
Copy link

cla-bot bot commented Nov 19, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tuditi.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

2 similar comments
Copy link

cla-bot bot commented Nov 19, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tuditi.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Nov 20, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tuditi.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@tmontaigu
Copy link
Contributor

Can you squash all commits into 1 single commit and fix the gpg signing ?

@cla-bot cla-bot bot added the cla-signed label Nov 20, 2024
@Tuditi Tuditi force-pushed the fix/comparison-le branch 2 times, most recently from 32e7208 to 78c83e3 Compare November 20, 2024 13:14
@Tuditi
Copy link
Contributor Author

Tuditi commented Nov 21, 2024

I'll reopen the PR, since GH seems to be stuck on processing my push since yesterday.

image

@Tuditi Tuditi closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants