chore(hlapi): stabilize FheTypes #1786
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceTDrinker
reviewed
Nov 15, 2024
Comment on lines
-25
to
32
| Type_FheBool, | ||
| Type_FheBool = 0, | ||
| Type_FheUint2, | ||
| Type_FheUint4, | ||
| Type_FheUint4 = 1, | ||
| Type_FheUint6, | ||
| Type_FheUint8, | ||
| Type_FheUint8 = 2, | ||
| Type_FheUint10, | ||
| Type_FheUint12, | ||
| Type_FheUint14, |
There was a problem hiding this comment.
We need all variants to have a value otherwise we'll have an issue later on, I'll check with BC for that and the fact we have more types than them
There was a problem hiding this comment.
we probably need a test (with a macro) to check that all values match between the C Enum and the HL one
IceTDrinker
requested changes
Nov 15, 2024
mayeul-zama
force-pushed
the
mz/stabilize_fhe_types
branch
2 times, most recently
from
cdb6d94
to
de4a613
Compare
IceTDrinker
reviewed
Nov 26, 2024
tfhe/src/high_level_api/mod.rs
Outdated
Comment on lines
131
to
133
| #[derive(Copy, Clone, PartialEq, Eq, Debug)] | ||
| pub enum FheTypes { |
There was a problem hiding this comment.
this needs to be marked #[repr(i32)] and all the types need to have a value associated, then we'll check with BC it's fine with them
mayeul-zama
force-pushed
the
mz/stabilize_fhe_types
branch
from
de4a613
to
08752cd
Compare
IceTDrinker
reviewed
Dec 2, 2024
Comment on lines
42
to
44
| Type_FheInt2, | ||
| Type_FheInt4, | ||
| Type_FheInt6, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.