feat(ui): add zoom in/out buttons and menu #1266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for looking into this. I think adding more buttons to the toolbar results in UI clutter. Nowadays major browsers moved to one menu button. I'd say Zeal should follow the trend. That would also allow us to address #1251. Would you be willing to give menu button try? |
|
Thanks, this is a good idea, I will move those buttons to a menu button ASAP. |
trollixx
requested changes
Sep 6, 2020
Serge45
force-pushed
the
feat/zoom-buttons
branch
2 times, most recently
from
b1b3c74
to
1957dd2
Compare
trollixx
reviewed
Sep 8, 2020
|
Ok, sure. There are some ugly codes to make widget in |
trollixx
force-pushed
the
feat/zoom-buttons
branch
from
24ca95a
to
b6aeec4
Compare
trollixx
force-pushed
the
feat/zoom-buttons
branch
from
b6aeec4
to
be8af52
Compare
trollixx
changed the title
trollixx
changed the title
An event filter was also added to prevent pop-up menu closing while zoom in/out actions triggered.
A custom QStyleSheet must be applied to BrowserZoomWidget since QMenu does not handle item highlighting of QWidget in QWidgetAction.
trollixx
force-pushed
the
feat/zoom-buttons
branch
from
be8af52
to
ee6c552
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #1256, I added zoom in, zoom out and reset zoom items to the edit menu. Two convenient tool buttons for zoom in and zoom out were added to browser tab as well.