Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bedrock Cloud Model provider #21092

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

5herlocked
Copy link

Closes #16544

Release Notes:

  • Added support for Bedrock as an FM provider
  • Added rudimentary support for AWS credential management to Zed

@5herlocked
Copy link
Author

This still needs to be updated to the new method of managing models, going to spend the next couple of weeks migrating to it.

@5herlocked
Copy link
Author

5herlocked commented Nov 23, 2024

Zed maintainers, would appreciate some guidance on how the ZedPro things are setup and if it makes sense to pass the Bedrock models into it.

On a cursory reading of the feature, i don't believe it does -- however, i am open to working with the bedrock service team to make it a reality.

@maxdeviant maxdeviant changed the title feature: Bedrock Cloud Model provider Add Bedrock Cloud Model provider Nov 23, 2024
@rgbkrk
Copy link
Member

rgbkrk commented Nov 23, 2024

I don't think you need to pass through the bedrock models through the collab service, as Zed would need to run their own bedrock setup. I'd just do the API key / AWS credentials route.

@SomeoneToIgnore
Copy link
Contributor

Unfortunately, our CLA bot is broken, so I have to substitute for it for a while:

We require contributors to sign our Contributor License Agreement, and we don't have @5herlocked on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@5herlocked
Copy link
Author

Will get it done post a legal review of the docs (just want to make sure AWS doesn't have an issue with it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AWS Bedrock as an Assistant provider
3 participants