Implement Global Disputes #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chralt98
commented
Jul 6, 2022
Chralt98
added
s:review-needed
Chralt98
added
s:review-needed
maltekliemann
suggested changes
Nov 7, 2022
zrml/global-disputes/src/lib.rs
Outdated
| debug_assert!(false); | ||
| } | ||
|
|
||
| // because of division remainders allow some dust |
There was a problem hiding this comment.
But you shouldn't assume that remainder <= 100. If there are more than 100 outcome owners, this is no longer true. I would either remove the warning completely or check if remainder != reward_account_free_balance.checked_rem(&owners_len_in_balance). I think I'd go with the first option. While I like that you add some sanity checks, I don't think it's good style to clutter the code with lots of assumptions.
Chralt98
added
s:in-progress
Chralt98
added
s:review-needed
Chralt98
commented
Nov 10, 2022
maltekliemann
approved these changes
Nov 10, 2022
sea212
approved these changes
Nov 10, 2022
sea212
added
s:accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #654 Fixes #489
Problem
There is no implementation for voting on multiple outcomes.
Solution
https://github.com/zeitgeistpm/zeitgeist/blob/0f197fcf68e087043dc97b494924acf7cb7bd72f/zrml/global-disputes/README.md
--features with-global-disputeson battery station to get the global disputes system working.